Use .text() instead of .html() so that entities aren't escaped by cheerio #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is still valid, independent of the highlighter switch, right? |
Member
Author
|
Yep - in experimenting with the new highlighter, I realised the bug was happening with any highlighter and so this was clearly a separate bug. |
Member
|
I need to get my local setup fixed to test this and other PRs. |
Member
|
Got my setup fixed; got this tested. Landed in da0d1a5 |
Member
|
Released 0.5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect syntax highlight was actually because calling .html() with cheerio was giving us back some of the html converted to entities. Calling .text() gives us input that highlights property. Hat tip to @mikesherov